Update GCP for L2 networking deployment #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimright
force-pushed
the
feature/gcp_l1_l2_updates
branch
from
20df06a
to
aa1f2ff
Compare
Chaffelson
suggested changes
Jun 23, 2022
| @@ -134,6 +134,10 @@ infra__gcp_project: "{{ common__gcp_project }}" | |||
| infra__gcp_storage_location_data: "{{ infra.gcp.storage.path.data | default([infra__storage_name, infra__data_path] | join('-')) }}" | |||
| infra__gcp_storage_location_logs: "{{ infra.gcp.storage.path.logs | default([infra__storage_name, infra__logs_path] | join('-')) }}" | |||
|
|
|||
| infra__gcp_cloud_router_name: "{{ infra.gcp.network.router.name | default([infra__namespace, 'router'] | join('-')) }}" | |||
There was a problem hiding this comment.
These should be declared as standard suffixes and then referenced here, not input as static strings.
There was a problem hiding this comment.
Thanks @Chaffelson. Updated the code with those changes in commit 886b15e.
jimright
force-pushed
the
feature/gcp_l1_l2_updates
branch
from
886b15e
to
0b0390e
Compare
Co-authored-by: Jeremy Wietrzykowski <[email protected]> Co-authored-by: Jim Enright <[email protected]> Signed-off-by: Jim Enright <[email protected]>
Co-authored-by: Jeremy Wietrzykowski <[email protected]> Co-authored-by: Jim Enright <[email protected]> Signed-off-by: Jim Enright <[email protected]>
Co-authored-by: Jeremy Wietrzykowski <[email protected]> Co-authored-by: Jim Enright <[email protected]> Signed-off-by: Jim Enright <[email protected]>
jimright
force-pushed
the
feature/gcp_l1_l2_updates
branch
from
0b0390e
to
d51c5b4
Compare
wmudge
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to infrastructure and platform roles to support an L2 networking deployment on GCP.
Summary of changes:
use_public_ipparameter in thecloudera.cloud.envcall to follow the value ofenv.public_endpoint_access.Tested these changes to confirm that L2 environment was successfully deployed. Also tested that teardown completes successfully.
Changes done in collaboration with Jeremy Wietrzykowski (@ws30)